fix(sync): avoid broad target scans unless unmanaged patterns are enabled#6
Merged
fix(sync): avoid broad target scans unless unmanaged patterns are enabled#6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a logic/performance issue where
status/deploy/importcould walk the entire target tree (including$HOMEfortarget: ./) even when unmanaged behavior was not configured.What changed
status: whenon.import.add-unmanaged.includeoron.deploy.remove-unmanagedis configureddeploy: whenon.deploy.remove-unmanagedis configuredimport: whenon.import.add-unmanaged.includeis configuredENOTDIRduring target probing as missing path (instead of hard-failing reads).Why
With a broad sync like:
and no unmanaged patterns configured, the expected behavior is to evaluate manifest paths only, not scan unrelated paths in
$HOME.Validation
go test ./...go test -tags=contract ./...go test -tags=integration ./...bash scripts/ci/run-static-checks.sh truebash scripts/ci/run-tests.sh contract linux trueManual check
Reproduced and verified from source build:
dotfiles-manager status --config ~/.dotfiles/.dotfiles-manager.yaml --log-level debugRead failed: /Users/shpoontin the default (no unmanaged patterns) case.